Add methods to create proxy on arbitrary connections #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+17
to
+38
| static void create(const Glib::RefPtr<Gio::DBus::Connection> &connection, | ||
| Gio::DBus::ProxyFlags proxyFlags, | ||
| const std::string &name, | ||
| const std::string &objectPath, | ||
| const Gio::SlotAsyncReady &slot, | ||
| const Glib::RefPtr<Gio::Cancellable> &cancellable = {}); | ||
| static void createForBus(Gio::DBus::BusType busType, | ||
| Gio::DBus::ProxyFlags proxyFlags, | ||
| const std::string &name, | ||
| const std::string &objectPath, | ||
| const Gio::SlotAsyncReady &slot, | ||
| const Glib::RefPtr<Gio::Cancellable> &cancellable = {}); | ||
|
|
||
| static Glib::RefPtr<{{ interface.cpp_class_name_proxy }}> createForBusFinish (const Glib::RefPtr<Gio::AsyncResult> &result); | ||
| static Glib::RefPtr<{{ interface.cpp_class_name_proxy }}> createFinish(const Glib::RefPtr<Gio::AsyncResult> &result); | ||
| static Glib::RefPtr<{{ interface.cpp_class_name_proxy }}> create_sync( | ||
| const Glib::RefPtr<Gio::DBus::Connection> &connection, | ||
| Gio::DBus::ProxyFlags proxyFlags, | ||
| const std::string &name, | ||
| const std::string &objectPath, | ||
| const Glib::RefPtr<Gio::Cancellable> &cancellable = {}); | ||
|
|
||
| static Glib::RefPtr<{{ interface.cpp_class_name_proxy }}> createForBusFinish (const Glib::RefPtr<Gio::AsyncResult> &result); |
There was a problem hiding this comment.
Nit: maybe reorder so that "create()" and "createForBus()" methods are kept together (and in same order as in proxy.cpp.tmpl)?
|
Looks good to me except for minor nit. |
|
Can you add a tag to commit message before merging please. looks good to me. |
kursatkobya
approved these changes
Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows, for example, the creation of a peer to peer D-Bus connection over a socket.